outman/dify
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add validation and proper default for Opik URL

Browse Source 
Also add better documentation link for Opik configuration in the UI
This commit is contained in:
Boris Feld 2024-12-12 15:30:50 +01:00
parent e87865be80
commit a16be9ccb2
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
api/core/ops/entities/config_entity.py
View File

@ -69,12 +69,24 @@ class OpikConfig(BaseTracingConfig):
@field_validator("project") @field_validator("project")
@classmethod @classmethod
def set_value(cls, v, info: ValidationInfo): def project_validator(cls, v, info: ValidationInfo):
if v is None or v == "": if v is None or v == "":
v = "Default Project" v = "Default Project"
return v return v
@field_validator("url")
@classmethod
def url_validator(cls, v, info: ValidationInfo):
if v is None or v == "":
v = "https://www.comet.com/opik/api/"
if not v.startswith(("https://", "http://")):
raise ValueError("url must start with https:// or http://")
if not v.endswith("/api/"):
raise ValueError("url should ends with /api/")
return v
OPS_FILE_PATH = "ops_trace/" OPS_FILE_PATH = "ops_trace/"
OPS_TRACE_FAILED_KEY = "FAILED_OPS_TRACE" OPS_TRACE_FAILED_KEY = "FAILED_OPS_TRACE"

2
web/app/(commonLayout)/app/(appDetailLayout)/[appId]/overview/tracing/config.ts
View File

@ -3,5 +3,5 @@ import { TracingProvider } from './type'
export const docURL = { export const docURL = {
[TracingProvider.langSmith]: 'https://docs.smith.langchain.com/', [TracingProvider.langSmith]: 'https://docs.smith.langchain.com/',
[TracingProvider.langfuse]: 'https://docs.langfuse.com', [TracingProvider.langfuse]: 'https://docs.langfuse.com',
[TracingProvider.opik]: 'https://www.comet.com/docs/opik/', [TracingProvider.opik]: 'https://www.comet.com/docs/opik/tracing/integrations/dify#setup-instructions',
} }