From 10ad8ba82ca47ab4219b2d478726657a0c81021b Mon Sep 17 00:00:00 2001 From: kyatai Date: Tue, 14 Jan 2025 16:54:01 +0800 Subject: [PATCH 1/2] fix: custom image as copied app icon is ineffective --- api/services/app_dsl_service.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/services/app_dsl_service.py b/api/services/app_dsl_service.py index 15119247f8..18d672c893 100644 --- a/api/services/app_dsl_service.py +++ b/api/services/app_dsl_service.py @@ -346,7 +346,7 @@ class AppDslService: # Set icon type icon_type_value = icon_type or app_data.get("icon_type") - if icon_type_value in ["emoji", "link"]: + if icon_type_value in ["emoji", "link", "image"]: icon_type = icon_type_value else: icon_type = "emoji" From 4840ba46335f36c7884f8ac08b29e11b7c54863d Mon Sep 17 00:00:00 2001 From: fangkunyu Date: Wed, 15 Jan 2025 15:43:12 +0800 Subject: [PATCH 2/2] chore: remove duplicate code --- api/core/app/app_config/easy_ui_based_app/dataset/manager.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/api/core/app/app_config/easy_ui_based_app/dataset/manager.py b/api/core/app/app_config/easy_ui_based_app/dataset/manager.py index 646c4badb9..c723531735 100644 --- a/api/core/app/app_config/easy_ui_based_app/dataset/manager.py +++ b/api/core/app/app_config/easy_ui_based_app/dataset/manager.py @@ -119,9 +119,6 @@ class DatasetConfigManager: if not isinstance(config["dataset_configs"], dict): raise ValueError("dataset_configs must be of object type") - if not isinstance(config["dataset_configs"], dict): - raise ValueError("dataset_configs must be of object type") - need_manual_query_datasets = config.get("dataset_configs") and config["dataset_configs"].get( "datasets", {} ).get("datasets")