From c7b5a8fa79fd698c288bce9b307980acf5c10dee Mon Sep 17 00:00:00 2001
From: Joel <iamjoel007@gmail.com>
Date: Wed, 5 Mar 2025 14:12:18 +0800
Subject: [PATCH] chore: handle rename problem

---
 .../metadata/hooks/use-edit-dataset-metadata.ts    | 14 +++++++++++---
 .../metadata-dataset/dataset-metadata-drawer.tsx   |  2 +-
 web/service/knowledge/use-metadata.ts              | 11 +++--------
 3 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/web/app/components/datasets/metadata/hooks/use-edit-dataset-metadata.ts b/web/app/components/datasets/metadata/hooks/use-edit-dataset-metadata.ts
index 50a9840a1c..cd587c798d 100644
--- a/web/app/components/datasets/metadata/hooks/use-edit-dataset-metadata.ts
+++ b/web/app/components/datasets/metadata/hooks/use-edit-dataset-metadata.ts
@@ -45,9 +45,17 @@ const useEditDatasetMetadata = ({
   }, [checkName, doAddMetaData])
 
   const { mutate: doRenameMetaData } = useRenameMeta(datasetId)
-  const handleRename = useCallback((payload: MetadataItemWithValueLength) => {
-    doRenameMetaData(payload)
-  }, [doRenameMetaData])
+  const handleRename = useCallback(async (payload: MetadataItemWithValueLength) => {
+    const errorMsg = checkName(payload.name).errorMsg
+    if (errorMsg) {
+      Toast.notify({
+        message: errorMsg,
+        type: 'error',
+      })
+      return Promise.reject(new Error(errorMsg))
+    }
+    await doRenameMetaData(payload)
+  }, [checkName, doRenameMetaData])
 
   const { mutate: doDeleteMetaData } = useDeleteMetaData(datasetId)
   const handleDeleteMetaData = useCallback((metaDataId: string) => {
diff --git a/web/app/components/datasets/metadata/metadata-dataset/dataset-metadata-drawer.tsx b/web/app/components/datasets/metadata/metadata-dataset/dataset-metadata-drawer.tsx
index 5d3249873a..131e3eed63 100644
--- a/web/app/components/datasets/metadata/metadata-dataset/dataset-metadata-drawer.tsx
+++ b/web/app/components/datasets/metadata/metadata-dataset/dataset-metadata-drawer.tsx
@@ -152,7 +152,7 @@ const DatasetMetadataDrawer: FC<Props> = ({
       })
     }
     setIsShowRenameModal(false)
-  }, [userMetadata, currPayload?.id, onRename, templeName])
+  }, [userMetadata, currPayload?.id, onRename, templeName, t])
 
   const handleDelete = useCallback((payload: MetadataItemWithValueLength) => {
     return async () => {
diff --git a/web/service/knowledge/use-metadata.ts b/web/service/knowledge/use-metadata.ts
index ace725962a..4321d9de08 100644
--- a/web/service/knowledge/use-metadata.ts
+++ b/web/service/knowledge/use-metadata.ts
@@ -36,15 +36,10 @@ export const useRenameMeta = (datasetId: string) => {
   const invalidDatasetMetaData = useInvalidDatasetMetaData(datasetId)
   return useMutation({
     mutationFn: async (payload: MetadataItemWithValueLength) => {
-      // datasetMetaData = datasetMetaData.map((item) => {
-      //   if (item.id === payload.id)
-      //     return payload
-
-      //   return item
-      // })
       await patch(`/datasets/${datasetId}/metadata/${payload.id}`, {
-        name: payload.name,
-        type: payload.type,
+        body: {
+          name: payload.name,
+        },
       })
       await invalidDatasetMetaData()
       return Promise.resolve(true)