From fd4d7e900245b93c0fde3e87ca646ea85950c8dc Mon Sep 17 00:00:00 2001
From: Yi <yxiaoisme@gmail.com>
Date: Mon, 30 Sep 2024 11:58:46 +0800
Subject: [PATCH] fix: edit dataset card from datasets page, naming

---
 web/app/(commonLayout)/datasets/Container.tsx     |  2 +-
 .../components/datasets/hit-testing/textarea.tsx  |  1 +
 .../components/datasets/rename-modal/index.tsx    | 15 +++++++++++----
 3 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/web/app/(commonLayout)/datasets/Container.tsx b/web/app/(commonLayout)/datasets/Container.tsx
index 2bb94f979a..e350a85354 100644
--- a/web/app/(commonLayout)/datasets/Container.tsx
+++ b/web/app/(commonLayout)/datasets/Container.tsx
@@ -91,7 +91,7 @@ const Container = () => {
               onClick={() => setShowExternalApiPanel(true)}
             >
               <ApiConnectionMod className='w-4 h-4 text-components-button-secondary-text' />
-              <div className='flex px-0.5 justify-center items-center gap-1 text-components-button-secondary-text system-sm-medium'>{t('dataset.externalAPI')}</div>
+              <div className='flex px-0.5 justify-center items-center gap-1 text-components-button-secondary-text system-sm-medium'>{t('dataset.externalAPIPanelTitle')}</div>
             </Button>
           </div>
         )}
diff --git a/web/app/components/datasets/hit-testing/textarea.tsx b/web/app/components/datasets/hit-testing/textarea.tsx
index 5d228dfa36..9f8b55f6c6 100644
--- a/web/app/components/datasets/hit-testing/textarea.tsx
+++ b/web/app/components/datasets/hit-testing/textarea.tsx
@@ -143,6 +143,7 @@ const TextAreaWithButton = ({
                 onSave={handleSaveExternalRetrievalSettings}
                 initialTopK={externalRetrievalSettings.top_k}
                 initialScoreThreshold={externalRetrievalSettings.score_threshold}
+                initialScoreThresholdEnabled={externalRetrievalSettings.score_threshold_enabled}
               />
             )
           }
diff --git a/web/app/components/datasets/rename-modal/index.tsx b/web/app/components/datasets/rename-modal/index.tsx
index a7e9e6e335..7e5fb228f7 100644
--- a/web/app/components/datasets/rename-modal/index.tsx
+++ b/web/app/components/datasets/rename-modal/index.tsx
@@ -26,6 +26,8 @@ const RenameDatasetModal = ({ show, dataset, onSuccess, onClose }: RenameDataset
   const [loading, setLoading] = useState(false)
   const [name, setName] = useState<string>(dataset.name)
   const [description, setDescription] = useState<string>(dataset.description)
+  const [externalKnowledgeId, setExternalKnowledgeId] = useState<string>(dataset.external_knowledge_info.external_knowledge_id)
+  const [externalKnowledgeApiId, setExternalKnowledgeApiId] = useState<string>(dataset.external_knowledge_info.external_knowledge_api_id)
 
   const onConfirm: MouseEventHandler = async () => {
     if (!name.trim()) {
@@ -34,12 +36,17 @@ const RenameDatasetModal = ({ show, dataset, onSuccess, onClose }: RenameDataset
     }
     try {
       setLoading(true)
+      const body: Partial<DataSet> & { external_knowledge_id?: string; external_knowledge_api_id?: string } = {
+        name,
+        description,
+      }
+      if (externalKnowledgeId && externalKnowledgeApiId) {
+        body.external_knowledge_id = externalKnowledgeId
+        body.external_knowledge_api_id = externalKnowledgeApiId
+      }
       await updateDatasetSetting({
         datasetId: dataset.id,
-        body: {
-          name,
-          description,
-        },
+        body,
       })
       notify({ type: 'success', message: t('common.actionMsg.modifiedSuccessfully') })
       if (onSuccess)